Open
Conversation
Collaborator
Author
|
@greptile |
richyreachy
previously approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds a new Clang CI job for
linux-x64by extending the existing reusable workflow (03-macos-linux-build.yml) with an optionalcompilerinput (defaulting togcc) and wiring up a newbuild-and-test-linux-x64-clangjob in the pipeline orchestrator.Key changes:
compilerworkflow input (gcc|clang) with a default ofgcc, keeping all existing callers unaffected.apt-get install clangstep andCC/CXXenvironment variable injection whencompiler == 'clang'.lscpustep added for all Linux runners.build-and-test-linux-x64-clangjob in01-ci-pipeline.ymltargetingubuntu-24.04.Issue found:
Install Clangstep conditions only oninputs.compiler == 'clang'without also checkingrunner.os == 'Linux'. Becauseapt-getdoes not exist on macOS and macOS runners already include Apple Clang, the step would fail if this workflow is ever invoked withcompiler: clangagainst a macOS runner. The immediately followingPrint CPU infostep correctly usesrunner.os == 'Linux'as a guard.Confidence Score: 4/5
compiler: clangon a macOS runner.ubuntu-24.04, so there is no immediate breakage. However, the missingrunner.os == 'Linux'guard on theInstall Clangstep is a real forward-compatibility issue that is trivial to fix now before it causes a hard failure later.03-macos-linux-build.yml— theInstall Clangstep needs an additional OS guard.Important Files Changed
build-and-test-linux-x64-clangCI job that reuses the existing reusable workflow withcompiler: clangandos: ubuntu-24.04. Change is straightforward and correct.compilerinput, an apt-based Clang install step, CPU info logging, andCC/CXXenv-var injection. The Clang install step is missing anrunner.os == 'Linux'guard, which would cause failures if the workflow is ever called withcompiler: clangon a macOS runner.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[01-ci-pipeline.yml\nMain Workflow Trigger] --> B[lint job] B --> C[build-and-test-macos-arm64\ncompiler: gcc default] B --> D[build-and-test-linux-arm64\ncompiler: gcc default] B --> E[build-and-test-linux-x64\ncompiler: gcc default] B --> F[build-and-test-linux-x64-clang\ncompiler: clang ⭐ NEW] B --> G[build-android] C --> H[03-macos-linux-build.yml] D --> H E --> H F --> H H --> I{inputs.compiler == 'clang'} I -- Yes --> J[apt-get install clang\n⚠️ no runner.os guard] I -- No --> K[skip install] J --> L[Set CC=clang CXX=clang++] K --> M[CC/CXX unchanged] L --> N[Build & Test] M --> NLast reviewed commit: "add clang ci"